[Minting] Better filtering of zPiv serials in miner. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the miner detects the same zPiv serial already including in the block it is creating, it was not correctly continuing to the next transaction, and therefore was ultimately adding the tx to the block, which would later be rejected as invalid.
Fuzzbawls
changed the title
|
utACK |
|
been running with this for over 24 hours without any noticeable issue(s), and the code looks sound, so... ACK fc16763 |
|
Ack |
|
utACK and merging... |
Mrs-X
added a commit
that referenced
this pull request
Oct 27, 2017
fc16763 Better filtering of zPiv serials in miner. (presstab) Tree-SHA512: 76cad2475e8b59677ddeaf76243e8333c6bcb8ec1920b19781aa07657abd0cdbbb14f71f7e1bc37850474de7309ad3697cca39168a0b5be595ae36230745e556
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Oct 29, 2017
When the miner detects the same zPiv serial already including in the block it is creating, it was not correctly continuing to the next transaction, and therefore was ultimately adding the tx to the block, which would later be rejected as invalid. Github-Pull: PIVX-Project#316 Rebased-From: fc16763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the miner detects the same zPiv serial already including in the block it is creating, it was not correctly continuing to the next transaction, and therefore was ultimately adding the tx to the block, which would later be rejected as invalid.