Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zPIV] Fix bignum overloads when using OpenSSL #731

Merged
merged 1 commit into from
Oct 7, 2018

Conversation

Fuzzbawls
Copy link
Collaborator

Similar to the CBigNum() overloads when using GMP, there is no need to
use special pre-compiler logic for __APPLE__'s int64_t; just use
long long.

Similar to the `CBigNum()` overloads when using GMP, there is no need to
 use special pre-compiler logic for `__APPLE__`'s int64_t; just use
 `long long`.
@Fuzzbawls Fuzzbawls added this to the 3.2.0 milestone Oct 5, 2018
@ghost ghost assigned Fuzzbawls Oct 5, 2018
@ghost ghost added the review label Oct 5, 2018
Copy link

@Warrows Warrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link

@Mrs-X Mrs-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK and merging....

@Mrs-X Mrs-X merged commit 69459a3 into PIVX-Project:master Oct 7, 2018
Mrs-X added a commit that referenced this pull request Oct 7, 2018
69459a3 [zPIV] Fix bignum overloads when using OpenSSL (Fuzzbawls)

Tree-SHA512: 54aa584ea41524d995fa4ddb63c57f2a5c331f278bf77ccea698ef135d877ac0b3a5695a7430373d194fd87544606e423f588e28cef7603e0e8c4d5b164bd33c
@ghost ghost removed the review label Oct 7, 2018
@Fuzzbawls Fuzzbawls deleted the 2018_bignum-overloads branch January 9, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants