Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High DPI support #29

Merged
merged 5 commits into from
Aug 29, 2022
Merged

High DPI support #29

merged 5 commits into from
Aug 29, 2022

Conversation

PhoenixBound
Copy link
Collaborator

@PhoenixBound PhoenixBound commented Mar 13, 2022 •
edited
Loading

Still some remaining issues before this can be merged:

  • Some text gets cut off at the bottom of the groupboxes, when viewing the tracker's state window. Tired 3 a.m. me thinks this may be related to negative values of xsize and ysize being unintuitive in the way they work (adding the entire width of the window area and not taking into account the top left corner of the window), but that's probably not right.
  • The tabs font doesn't scale the way I want -- specifically, it behaves differently when compiled with MSVC/Windows SDK headers, compared to MinGW-W64 headers. I am not sure of the cause of this yet but I'll be looking into it.

@PhoenixBound PhoenixBound marked this pull request as ready for review May 21, 2022 04:36
@PhoenixBound
Make fixed-width font Consolas and fix sizing of tabs
2f73b3e 
It doesn't have all the same serifs, but it looks a lot nicer, comes with
Windows since Vista, and it behaves a lot nicer with the scaling code I used.

There's clearly something funny going on with NONCLIENTMETRICS. I got a value of
8 for iPaddedBorderWidth when using the Windows SDK in MSVC, but 0 when using
MinGW-W64. I'm not sure if this is due to a difference in the size of a struct
or something else.
@ChrisBlueStone ChrisBlueStone merged commit 58879c6 into PKHackers:master Aug 29, 2022
@PhoenixBound PhoenixBound mentioned this pull request Sep 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhoenixBound @ChrisBlueStone