Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supporting chameleon finetuning #36

Merged
merged 5 commits into from
Aug 6, 2024
Merged

feat: supporting chameleon finetuning #36

merged 5 commits into from
Aug 6, 2024

Conversation

htlou
Copy link
Contributor

@htlou htlou commented Aug 5, 2024

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #1314520 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@htlou htlou changed the title Supporting Chameleon finetuning Feat: Supporting Chameleon finetuning Aug 5, 2024
cby-pku
cby-pku approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@cby-pku cby-pku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woaw! Great Work~ LGTM

@htlou htlou mentioned this pull request Aug 5, 2024
Closed
2 tasks
@Gaiejj Gaiejj changed the title Feat: Supporting Chameleon finetuning feat: supporting chameleon finetuning Aug 6, 2024
Gaiejj
Gaiejj requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@Gaiejj Gaiejj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve these issues

align_anything/datasets/text_to_text/supervised.py Outdated Show resolved Hide resolved
align_anything/datasets/ti_to_ti/supervised.py Outdated Show resolved Hide resolved
align_anything/datasets/ti_to_ti/supervised.py Outdated Show resolved Hide resolved
align_anything/datasets/ti_to_ti/supervised.py Outdated Show resolved Hide resolved
align_anything/trainers/ti_to_ti/dpo.py Outdated Show resolved Hide resolved
align_anything/trainers/ti_to_ti/ppo.py Outdated Show resolved Hide resolved
@htlou htlou requested a review from Gaiejj August 6, 2024 07:44
@htlou
Copy link
Contributor Author

htlou commented Aug 6, 2024

Please resolve these issues

I fixed them all ❤️

Gaiejj
Gaiejj approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💗

@htlou htlou merged commit 6357bce into PKU-Alignment:main Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gaiejj Gaiejj Gaiejj approved these changes

@cby-pku cby-pku cby-pku approved these changes

@XuyaoWang XuyaoWang Awaiting requested review from XuyaoWang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@htlou @Gaiejj @cby-pku