Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why average actor's gradient in DDPG but not in SAC ? #252

Closed
3 tasks done
Gaiejj opened this issue Jul 1, 2023 · 2 comments
Closed
3 tasks done

[Question] Why average actor's gradient in DDPG but not in SAC ? #252

Gaiejj opened this issue Jul 1, 2023 · 2 comments
Labels
algorithm Some issues about algorithm codestyle update codestyple question Further information is requested

Comments

@Gaiejj
Copy link
Member

Gaiejj commented Jul 1, 2023

Required prerequisites

Questions

We utilize distributed.avg_grads to average the gradients of the actor and critic network in DDPG, but not in SAC's actor network. In fact, due to the current lack of support for off-policy algorithms in the A3C parallel paradigm (preliminary checks are present in the omnisafe/algorithms/algo_wrapper.py file, and off-policy algorithms will not initiate training in the A3C parallel paradigm), in practice, gradient averaging is not performed during the training process of off-policy algorithms. A future pull request will removes redundant code, enhances readability, and does not affect the performance of the algorithm.

@Gaiejj Gaiejj added question Further information is requested algorithm Some issues about algorithm codestyle update codestyple labels Jul 1, 2023
@Gaiejj
Copy link
Member Author

Gaiejj commented Jul 1, 2023

Pull request #253 solve it.

@zmsn-2077
Copy link
Member

Already approve PR #253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Some issues about algorithm codestyle update codestyple question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants