Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(off-policy): clear redundant distributed grad average #253

Merged
merged 2 commits into from
Jul 2, 2023

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Jul 1, 2023

Description

Remove redundant distributed average gradient in off-policy algorithms

Motivation and Context

Resolve issue #252

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@codecov-commenter
Copy link

Codecov Report

Merging #253 (df234a3) into main (1a99b20) will increase coverage by 0.03%.
The diff coverage is 71.43%.

❗ Current head df234a3 differs from pull request most recent head 8f9d415. Consider uploading reports for the commit 8f9d415 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   96.98%   97.01%   +0.03%     
==========================================
  Files         138      138              
  Lines        6994     6989       -5     
==========================================
- Hits         6783     6780       -3     
+ Misses        211      209       -2     
Impacted Files Coverage Δ
omnisafe/algorithms/off_policy/sac.py 100.00% <ø> (ø)
omnisafe/algorithms/off_policy/td3.py 100.00% <ø> (ø)
omnisafe/algorithms/algo_wrapper.py 94.79% <60.00%> (+0.11%) ⬆️
omnisafe/algorithms/off_policy/ddpg.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Gaiejj Gaiejj merged commit af2951d into PKU-Alignment:main Jul 2, 2023
4 checks passed
@Gaiejj Gaiejj deleted the dev-off branch September 5, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants