feat: support policy evaluation #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaiejj
requested review from
rockmagma02 and
zmsn-2077
and removed request for
rockmagma02
| @@ -17,6 +17,7 @@ | |||
| from omnisafe import algorithms | |||
| from omnisafe.algorithms import ALGORITHMS | |||
| from omnisafe.algorithms.algo_wrapper import AlgoWrapper as Agent | |||
| from omnisafe.evaluator import Evaluator | |||
|
|
|||
| # from omnisafe.algorithms.env_wrapper import EnvWrapper as Env | |||
There was a problem hiding this comment.
Suggested change
| # from omnisafe.algorithms.env_wrapper import EnvWrapper as Env |
omnisafe/evaluator.py
Outdated
| print(f'Episode cost: {ep_cost}') | ||
| print(f'Episode length: {length}') | ||
|
|
||
| print('#' * 50) |
| done = False | ||
| while not done and step <= 2000: # a big number to make sure the episode will end | ||
| with torch.no_grad(): | ||
| act = self._actor.predict(obs, deterministic=False) |
There was a problem hiding this comment.
why deterministic = False?
zmsn-2077
reviewed
Mar 8, 2023
omnisafe/common/normalizer.py
Outdated
| @@ -14,7 +14,7 @@ | |||
| # ============================================================================== | |||
| """Implementation of Vector Buffer.""" | |||
There was a problem hiding this comment.
Vector Buffer should not appear in this file.
zmsn-2077
reviewed
Mar 8, 2023
| self.__set_render_mode(play, save_replay) | ||
|
|
||
| def __set_render_mode(self, play: bool = True, save_replay: bool = True): | ||
| """Set the render mode. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
I think the Args in the comment do not match the real function arguments.
zmsn-2077
reviewed
Mar 8, 2023
|
|
||
| Args: | ||
| env (gym.Env): The environment. | ||
| actor (omnisafe.actor.Actor): The actor. | ||
| save_dir (str): directory where the model is saved. |
zmsn-2077
reviewed
Mar 8, 2023
omnisafe/evaluator.py
Outdated
|
|
||
| Returns: | ||
| episode_rewards (list): list of episode rewards. |
There was a problem hiding this comment.
need to fix,
return ( episode_rewards, episode_costs, )
rockmagma02
approved these changes
Mar 9, 2023
zmsn-2077
pushed a commit
to zmsn-2077/omnisafe_zmsn
that referenced
this pull request
Mar 14, 2023
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
zmsn-2077
pushed a commit
to zmsn-2077/omnisafe_zmsn
that referenced
this pull request
Mar 14, 2023
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
zmsn-2077
pushed a commit
to zmsn-2077/omnisafe_zmsn
that referenced
this pull request
Mar 14, 2023
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
zmsn-2077
pushed a commit
that referenced
this pull request
Mar 14, 2023
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
zmsn-2077
pushed a commit
that referenced
this pull request
Mar 15, 2023
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: support policy evaluation
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)