Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rollout, exp_grid): fix logdir path conflict #145

Merged
merged 4 commits into from
Mar 13, 2023
Merged

fix(rollout, exp_grid): fix logdir path conflict #145

merged 4 commits into from
Mar 13, 2023

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Mar 10, 2023

Description

  1. Explicitly distinguish the terminated and truncated.
  2. Fix the parent path named by the config in exp_grid.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@zmsn-2077 zmsn-2077 changed the title fix(rollout, exp_grid): fix some bugs fix(rollout, exp_grid): fix logdir path conflict Mar 13, 2023
@friedmainfunction @zmsn-2077
update comment
4da04f3 
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
zmsn-2077
zmsn-2077 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zmsn-2077 zmsn-2077 merged commit 98b22b6 into PKU-Alignment:dev Mar 13, 2023
zmsn-2077 added a commit to zmsn-2077/omnisafe_zmsn that referenced this pull request Mar 14, 2023
@muchvo @zmsn-2077 @friedmainfunction
fix(rollout, exp_grid): fix logdir path conflict (PKU-Alignment#145)
8829766 
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
zmsn-2077 added a commit to zmsn-2077/omnisafe_zmsn that referenced this pull request Mar 14, 2023
@muchvo @zmsn-2077 @friedmainfunction
fix(rollout, exp_grid): fix logdir path conflict (PKU-Alignment#145)
06345b6 
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
zmsn-2077 added a commit to zmsn-2077/omnisafe_zmsn that referenced this pull request Mar 14, 2023
@muchvo @zmsn-2077 @friedmainfunction
fix(rollout, exp_grid): fix logdir path conflict (PKU-Alignment#145)
4b9bb33 
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
zmsn-2077 added a commit that referenced this pull request Mar 14, 2023
@muchvo @zmsn-2077 @friedmainfunction
fix(rollout, exp_grid): fix logdir path conflict (#145)
78ec6bd 
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
zmsn-2077 added a commit that referenced this pull request Mar 15, 2023
@muchvo @zmsn-2077 @friedmainfunction
fix(rollout, exp_grid): fix logdir path conflict (#145)
268cb9d 
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
zmsn-2077 added a commit that referenced this pull request Mar 18, 2023
@muchvo @pre-commit-ci
@rockmagma02 @zmsn-2077 @friedmainfunction @Gaiejj @1Asan
feat: support command line interfaces for omnisafe (#144)
3c2daf0 
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
Co-authored-by: Gaiejj <524339208@qq.com>
Co-authored-by: zmsn-2077 <jiamg.ji@gmail.com>
Co-authored-by: Ruiyang Sun <rockmagma02@gmail.com>
Co-authored-by: Jiayi Zhou <108712610+Gaiejj@users.noreply.github.com>
Co-authored-by: 1Asan <99461435+1Asan@users.noreply.github.com>
fix(algo): fix no return in algo_wrapper::learn (#122)
fix(logger, wrapper): support csv file and velocity tasks (#131)
fix typo. (#134)
fix(ppo): fix entropy loss (#135)
fix bugs (#136)
fix: support new config for exp_grid (#142)
fix(rollout, exp_grid): fix logdir path conflict (#145)
fix(on-policy): fix the second order algorithms performance (#147)
@Dtrc2207 Dtrc2207 mentioned this pull request Mar 19, 2023
Merged
15 tasks
zmsn-2077 added a commit that referenced this pull request Mar 19, 2023
@muchvo @pre-commit-ci
@rockmagma02 @zmsn-2077 @friedmainfunction @Gaiejj @1Asan
feat: support command line interfaces for omnisafe (#144)
12dbced 
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
Co-authored-by: Gaiejj <524339208@qq.com>
Co-authored-by: zmsn-2077 <jiamg.ji@gmail.com>
Co-authored-by: Ruiyang Sun <rockmagma02@gmail.com>
Co-authored-by: Jiayi Zhou <108712610+Gaiejj@users.noreply.github.com>
Co-authored-by: 1Asan <99461435+1Asan@users.noreply.github.com>
fix(algo): fix no return in algo_wrapper::learn (#122)
fix(logger, wrapper): support csv file and velocity tasks (#131)
fix typo. (#134)
fix(ppo): fix entropy loss (#135)
fix bugs (#136)
fix: support new config for exp_grid (#142)
fix(rollout, exp_grid): fix logdir path conflict (#145)
fix(on-policy): fix the second order algorithms performance (#147)
@Gaiejj Gaiejj mentioned this pull request Mar 20, 2023
Closed
3 tasks
zmsn-2077 added a commit that referenced this pull request Mar 26, 2023
@muchvo @pre-commit-ci
@rockmagma02 @zmsn-2077 @friedmainfunction @Gaiejj @1Asan
feat: support command line interfaces for omnisafe (#144)
d5e2814 
Co-authored-by: borong <borongzh@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: ruiyang sun <rockmagma02@gmail.com>
Co-authored-by: zmsn-2077 <73586554+zmsn-2077@users.noreply.github.com>
Co-authored-by: friedmainfunction <73703265+friedmainfunction@users.noreply.github.com>
Co-authored-by: Gaiejj <524339208@qq.com>
Co-authored-by: zmsn-2077 <jiamg.ji@gmail.com>
Co-authored-by: Ruiyang Sun <rockmagma02@gmail.com>
Co-authored-by: Jiayi Zhou <108712610+Gaiejj@users.noreply.github.com>
Co-authored-by: 1Asan <99461435+1Asan@users.noreply.github.com>
fix(algo): fix no return in algo_wrapper::learn (#122)
fix(logger, wrapper): support csv file and velocity tasks (#131)
fix typo. (#134)
fix(ppo): fix entropy loss (#135)
fix bugs (#136)
fix: support new config for exp_grid (#142)
fix(rollout, exp_grid): fix logdir path conflict (#145)
fix(on-policy): fix the second order algorithms performance (#147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmsn-2077 zmsn-2077 zmsn-2077 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@muchvo @zmsn-2077 @friedmainfunction