Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix autoreset wrapper #167

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Conversation

r-y1
Copy link
Contributor

@r-y1 r-y1 commented Mar 20, 2023

Description

  1. Fix autoreset wrapper

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zmsn-2077 zmsn-2077 added the bug Something isn't working label Mar 25, 2023
@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2f04f4a) 86.43% compared to head (df7e6b7) 86.44%.

❗ Current head df7e6b7 differs from pull request most recent head 6255f4e. Consider uploading reports for the commit 6255f4e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #167   +/-   ##
=======================================
  Coverage   86.43%   86.44%           
=======================================
  Files          80       80           
  Lines        3760     3762    +2     
=======================================
+ Hits         3250     3252    +2     
  Misses        510      510           
Impacted Files Coverage Δ
omnisafe/algorithms/on_policy/base/ppo.py 100.00% <ø> (ø)
omnisafe/algorithms/on_policy/base/trpo.py 89.85% <ø> (ø)
omnisafe/algorithms/on_policy/first_order/cup.py 96.05% <ø> (ø)
...nisafe/algorithms/on_policy/naive_lagrange/crpo.py 90.90% <ø> (-1.10%) ⬇️
...afe/algorithms/on_policy/naive_lagrange/ppo_lag.py 100.00% <ø> (ø)
...fe/algorithms/on_policy/naive_lagrange/trpo_lag.py 100.00% <ø> (ø)
...isafe/algorithms/on_policy/penalty_function/ipo.py 93.75% <ø> (ø)
...isafe/algorithms/on_policy/penalty_function/p3o.py 100.00% <ø> (ø)
omnisafe/algorithms/on_policy/second_order/cpo.py 73.42% <ø> (ø)
omnisafe/algorithms/on_policy/second_order/pcpo.py 100.00% <ø> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@friedmainfunction friedmainfunction merged commit 68b9be8 into PKU-Alignment:dev Mar 26, 2023
zmsn-2077 pushed a commit that referenced this pull request Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants