-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add offline algorithms #175
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #175 +/- ##
===========================================
- Coverage 86.01% 74.99% -11.03%
===========================================
Files 82 98 +16
Lines 4226 5166 +940
===========================================
+ Hits 3635 3874 +239
- Misses 591 1292 +701
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
1e57624
to
094ceb9
Compare
a354e5d
to
c642a7f
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #175 +/- ##
==========================================
- Coverage 95.99% 95.29% -0.70%
==========================================
Files 118 134 +16
Lines 5992 6904 +912
==========================================
+ Hits 5752 6579 +827
- Misses 240 325 +85
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some common mistakes have been mentioned in PR #221 's comment: #221 (review).
Please follow it then make sure the code can pass make mypy
Please upload the benchmark exp results with these algorithms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files are polish needed, but this Pull Request can be merged first and I will fix them in future Pull Request.
Description
feat: add offline algorithms.
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format
. (required)make lint
. (required)make test
pass. (required)