Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add MANIFEST.in #182

Merged
merged 1 commit into from
Mar 28, 2023
Merged

chore: add MANIFEST.in #182

merged 1 commit into from
Mar 28, 2023

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Mar 27, 2023

Description

  1. add MANIFEST.in.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (eb5358e) 86.11% compared to head (447e617) 86.11%.

❗ Current head 447e617 differs from pull request most recent head 073b23f. Consider uploading reports for the commit 073b23f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #182   +/-   ##
=======================================
  Coverage   86.11%   86.11%           
=======================================
  Files          82       82           
  Lines        4111     4111           
=======================================
  Hits         3540     3540           
  Misses        571      571           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zmsn-2077 zmsn-2077 merged commit e9fbdc7 into PKU-Alignment:dev Mar 28, 2023
Gaiejj pushed a commit that referenced this pull request Mar 28, 2023
Co-authored-by: muchvo <borongzh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants