Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update hyper-parameters for first-order algorithms #199

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Apr 2, 2023

Description

  1. Update hyper-parameters for first-order algorithms.

Motivation and Context

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a0a093b) 86.01% compared to head (8a680f6) 86.01%.

❗ Current head 8a680f6 differs from pull request most recent head 28e5f19. Consider uploading reports for the commit 28e5f19 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #199   +/-   ##
=======================================
  Coverage   86.01%   86.01%           
=======================================
  Files          82       82           
  Lines        4226     4226           
=======================================
  Hits         3635     3635           
  Misses        591      591           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

benchmarks/README.md Outdated Show resolved Hide resolved
benchmarks/README.md Outdated Show resolved Hide resolved
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@muchvo muchvo merged commit b2bcc84 into PKU-Alignment:dev Apr 5, 2023
4 checks passed
@muchvo muchvo deleted the pr_first_order branch April 5, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants