feat: add model-based algorithms #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdadong
force-pushed
the
dev-modelbase-plan
branch
from
fa69e8c
to
578c744
Compare
zmsn-2077
requested changes
Apr 15, 2023
rockmagma02
suggested changes
Apr 15, 2023
hdadong
force-pushed
the
dev-modelbase-plan
branch
2 times, most recently
from
c37c51f
to
602f6a2
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #212 +/- ##
==========================================
- Coverage 97.00% 95.99% -1.01%
==========================================
Files 99 118 +19
Lines 4331 5987 +1656
==========================================
+ Hits 4201 5747 +1546
- Misses 130 240 +110
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hdadong
force-pushed
the
dev-modelbase-plan
branch
5 times, most recently
from
2777eda
to
5454ed9
Compare
zmsn-2077
reviewed
Apr 21, 2023
zmsn-2077
reviewed
Apr 21, 2023
zmsn-2077
reviewed
Apr 21, 2023
hdadong
force-pushed
the
dev-modelbase-plan
branch
3 times, most recently
from
a2874f9
to
0346df5
Compare
hdadong
force-pushed
the
dev-modelbase-plan
branch
from
0346df5
to
b5a900a
Compare
hdadong
force-pushed
the
dev-modelbase-plan
branch
from
a9e7d6f
to
2c38aa6
Compare
hdadong
force-pushed
the
dev-modelbase-plan
branch
from
85a21a2
to
0709d5b
Compare
Gaiejj
reviewed
May 2, 2023
| example: | ||
|
|
||
| ```python | ||
| path ='/home/username/omnisafe/omnisafe/examples/benchmarks/exp-x/Model-Based-Benchmarks' |
There was a problem hiding this comment.
May be relative path better. e.g. ./examples/benchmarks/exp-x/Model-Based-Benchmarks
rockmagma02
approved these changes
May 2, 2023
Gaiejj
reviewed
May 2, 2023
| kwargs(dict): The other keyword arguments. | ||
|
|
||
| Attributes: | ||
| _env_id (str): The environment id. |
There was a problem hiding this comment.
private attributes may not need docs.
Gaiejj
reviewed
May 2, 2023
| self._last_dynamics_update = 0 | ||
| self._last_policy_update = 0 | ||
| self._last_eval = 0 | ||
| self._first_log = False |
There was a problem hiding this comment.
Suggested change
| self._first_log = False | |
| self._first_log: bool = False |
The same with others.
Gaiejj
approved these changes
May 2, 2023
| """Get lidar from numpy coordinate. | ||
|
|
||
| Args: | ||
| obs (np.ndarray): The observation. |
There was a problem hiding this comment.
Suggested change
| obs (np.ndarray): The observation. | |
| obs (torch.Tensor): The observation. |
| else None | ||
| ) | ||
|
|
||
| def render(self, *args: str, **kwargs: int) -> Any: |
| }, | ||
| ) | ||
|
|
||
| def _reset_log(self, idx: int | None = None) -> None: # pylint: disable=unused-argument |
There was a problem hiding this comment.
why unused-argument idx maintained ?
|
Open a fix request, then fix this code details. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add model-based algorithms
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)