Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean some trivial code #214

Merged
merged 24 commits into from
May 4, 2023
Merged

chore: clean some trivial code #214

merged 24 commits into from
May 4, 2023

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Apr 16, 2023

Description

  1. Clean some trivial code
  2. Update examples

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2023

Codecov Report

Merging #214 (ebd184e) into dev (b821adf) will decrease coverage by 0.03%.
The diff coverage is 32.00%.

❗ Current head ebd184e differs from pull request most recent head eb9bc0e. Consider uploading reports for the commit eb9bc0e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #214      +/-   ##
==========================================
- Coverage   95.99%   95.96%   -0.03%     
==========================================
  Files         118      118              
  Lines        5987     5992       +5     
==========================================
+ Hits         5747     5750       +3     
- Misses        240      242       +2     
Impacted Files Coverage Δ
omnisafe/common/statistics_tools.py 95.54% <0.00%> (-0.61%) ⬇️
omnisafe/utils/exp_grid_tools.py 50.00% <25.00%> (-41.67%) ⬇️
omnisafe/common/experiment_grid.py 96.43% <100.00%> (ø)
omnisafe/utils/command_app.py 84.21% <100.00%> (+9.60%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zmsn-2077
Copy link
Member

LGTM.

@Gaiejj Gaiejj added the codestyle update codestyple label Apr 27, 2023
@muchvo muchvo merged commit e0b1852 into PKU-Alignment:dev May 4, 2023
4 checks passed
@muchvo muchvo deleted the clean_code branch May 4, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codestyle update codestyple
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants