Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common/logger): refactor and simplify logger storage logic #216

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Refactor and simplify logger storage logic.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@codecov-commenter
Copy link

Codecov Report

Merging #216 (6e2ba34) into dev (d17aa77) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 6e2ba34 differs from pull request most recent head c430010. Consider uploading reports for the commit c430010 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #216      +/-   ##
==========================================
- Coverage   97.20%   97.15%   -0.05%     
==========================================
  Files          98       98              
  Lines        4291     4293       +2     
==========================================
  Hits         4171     4171              
- Misses        120      122       +2     
Impacted Files Coverage Δ
omnisafe/adapter/offpolicy_adapter.py 100.00% <ø> (ø)
omnisafe/algorithms/off_policy/ddpg_lag.py 100.00% <ø> (ø)
omnisafe/algorithms/off_policy/sac.py 100.00% <ø> (ø)
omnisafe/algorithms/off_policy/sac_lag.py 100.00% <ø> (ø)
omnisafe/algorithms/off_policy/td3.py 100.00% <ø> (ø)
omnisafe/algorithms/off_policy/td3_lag.py 100.00% <ø> (ø)
omnisafe/algorithms/on_policy/base/natural_pg.py 100.00% <ø> (ø)
omnisafe/algorithms/on_policy/base/trpo.py 90.14% <ø> (ø)
...mnisafe/algorithms/on_policy/first_order/focops.py 96.72% <ø> (ø)
...isafe/algorithms/on_policy/penalty_function/p3o.py 100.00% <ø> (ø)
... and 15 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After careful review, I agree with these changes.

@XuehaiPan XuehaiPan merged commit 4dd6209 into PKU-Alignment:dev Apr 17, 2023
4 checks passed
@XuehaiPan XuehaiPan deleted the refactor-logger branch April 17, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants