Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change link to PKU-Alignment #239

Merged
merged 5 commits into from
May 19, 2023
Merged

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented May 19, 2023

Description

Change link to PKU-Alignment

Motivation and Context

Since the name of organization has been changed to PKU-Alignment, all links related need to be redirected.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@Gaiejj Gaiejj added the documentation Improvements or additions to documentation label May 19, 2023
@@ -117,7 +117,7 @@ def __init__( # pylint: disable=too-many-arguments,too-many-locals
self._epoch: int = 0
self._first_row: bool = True
self._what_to_save: dict[str, Any] | None = None
self._data: dict[str, Deque[int | float] | list[int | float]] = {}
self._data: dict[str, deque[int | float] | list[int | float]] = {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newest ruff suggest this change, so I follow.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #239 (20f85c0) into dev (dee636e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 20f85c0 differs from pull request most recent head 8d062eb. Consider uploading reports for the commit 8d062eb to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev     #239      +/-   ##
==========================================
+ Coverage   96.96%   96.97%   +0.01%     
==========================================
  Files         134      134              
  Lines        6867     6867              
==========================================
+ Hits         6658     6659       +1     
+ Misses        209      208       -1     
Impacted Files Coverage Δ
omnisafe/common/logger.py 97.50% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit d853ad8 into PKU-Alignment:dev May 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants