feat: add ddpg, clean some code, modify algo_wrapper #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmsn-2077
requested review from
XuehaiPan,
calico-1226,
Gaiejj and
rockmagma02
hdadong
previously approved these changes
Dec 2, 2022
hdadong
approved these changes
Dec 2, 2022
Gaiejj
approved these changes
Dec 2, 2022
XuehaiPan
reviewed
Dec 2, 2022
XuehaiPan
reviewed
Dec 2, 2022
| seed: 0 | ||
| # Basic Configurations | ||
| epochs: 500 | ||
| steps_per_epoch: 30000 |
There was a problem hiding this comment.
Please follow the .editorconfig: ident with 2 spaces.
XuehaiPan
reviewed
Dec 2, 2022
| @@ -12,7 +12,7 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| # ============================================================================== | |||
|
|
|||
| """Implementation of the CPPOPid algorithm.""" | |||
There was a problem hiding this comment.
Please add an extra linebreak between the module docstring and imports. Same changes for other source files.
XuehaiPan
reviewed
Dec 2, 2022
| @@ -1,6 +1,6 @@ | |||
| ##### Project Specification ##### | |||
| **/runs | |||
|
|
|||
| **/scripts | |||
XuehaiPan
reviewed
Dec 2, 2022
| 'TRPOLag', | ||
| ], | ||
| 'model-based': ['MBPPOLag', 'SafeLoop'], | ||
| } |
There was a problem hiding this comment.
Constants should use ALL_CAPS names. Also, this may place after the import statements.
XuehaiPan
reviewed
Dec 2, 2022
zmsn-2077
changed the title
muchvo
pushed a commit
to muchvo/omnisafe
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
make format. (required)make lint. (required)make testpass. (required)