Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix adapter device and exp grid #243

Merged
merged 5 commits into from
May 26, 2023
Merged

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented May 25, 2023

Description

  • fix cuda support of saute, simmer and early mdp.
  • fix stastistics tools
  • fix experiment grid

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@Gaiejj Gaiejj added bug Something isn't working algorithm Some issues about algorithm codestyle update codestyple labels May 25, 2023
@Gaiejj Gaiejj requested a review from XuehaiPan as a code owner May 25, 2023 06:06
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #243 (ed410c0) into main (5085404) will decrease coverage by 0.01%.
The diff coverage is 91.67%.

❗ Current head ed410c0 differs from pull request most recent head 538b14a. Consider uploading reports for the commit 538b14a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   96.99%   96.97%   -0.01%     
==========================================
  Files         134      134              
  Lines        6867     6870       +3     
==========================================
+ Hits         6660     6662       +2     
- Misses        207      208       +1     
Impacted Files Coverage Δ
omnisafe/models/actor/perturbation_actor.py 96.30% <ø> (ø)
omnisafe/models/actor/vae_actor.py 100.00% <ø> (ø)
omnisafe/models/critic/q_critic.py 100.00% <ø> (ø)
omnisafe/models/offline/dice.py 95.65% <ø> (ø)
omnisafe/common/experiment_grid.py 94.25% <50.00%> (-0.40%) ⬇️
omnisafe/adapter/early_terminated_adapter.py 100.00% <100.00%> (ø)
omnisafe/adapter/saute_adapter.py 100.00% <100.00%> (ø)
omnisafe/adapter/simmer_adapter.py 100.00% <100.00%> (ø)
omnisafe/common/statistics_tools.py 97.42% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Gaiejj Gaiejj requested a review from rockmagma02 as a code owner May 25, 2023 06:49
Copy link
Collaborator

@muchvo muchvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj merged commit 651cb0e into PKU-Alignment:main May 26, 2023
4 checks passed
@Gaiejj Gaiejj deleted the dev-fix branch June 23, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Some issues about algorithm bug Something isn't working codestyle update codestyple
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants