Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(envs): Enable auto reset for MuJoCo envs #269

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

dtch1997
Copy link
Contributor

@dtch1997 dtch1997 commented Aug 23, 2023

Description

Enable AutoReset wrapper for Mujoco envs.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Closes #268

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #269 (772d0fd) into main (80c2c23) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 772d0fd differs from pull request most recent head 7432fc2. Consider uploading reports for the commit 7432fc2 to get more accurate results

@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files         138      138           
  Lines        6991     6991           
=======================================
  Hits         6782     6782           
  Misses        209      209           
Files Changed Coverage Δ
omnisafe/envs/mujoco_env.py 93.33% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Gaiejj Gaiejj self-assigned this Aug 24, 2023
@Gaiejj Gaiejj added bug Something isn't working environment Something related to the RL environment algorithm Some issues about algorithm labels Aug 24, 2023
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gaiejj Gaiejj changed the title Enable AutoReset for Mujoco envs fix(envs): Enable auto reset for MuJoCo envs Aug 24, 2023
@zmsn-2077 zmsn-2077 merged commit b343750 into PKU-Alignment:main Aug 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Some issues about algorithm bug Something isn't working environment Something related to the RL environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AutoReset not enabled for MuJoCo envs
4 participants