Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CPO, PolicyGradient, PCPO, FOCOPS): change the details and yaml files of on policy algorithm. #41

Merged
merged 15 commits into from
Dec 16, 2022

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Dec 16, 2022

Description

refactor(CPO, PolicyGradient, PCPO, FOCOPS): change the details and yaml files of on policy algorithm.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@Gaiejj Gaiejj changed the title refacrefactor(CPO, PolicyGradient, PCPO, FOCOPS): change the details and yaml files of on policy algorithm. refactor(CPO, PolicyGradient, PCPO, FOCOPS): change the details and yaml files of on policy algorithm. Dec 16, 2022
@zmsn-2077 zmsn-2077 self-requested a review December 16, 2022 10:43
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase omnisafe/dev and add all changes.

@zmsn-2077 zmsn-2077 self-requested a review December 16, 2022 11:38
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very meaningful modification.

Copy link
Member

@calico-1226 calico-1226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check carefully and approve

@Gaiejj Gaiejj merged commit b7abf89 into PKU-Alignment:dev Dec 16, 2022
@Gaiejj Gaiejj deleted the dev branch December 16, 2022 12:11
XuehaiPan added a commit that referenced this pull request Dec 22, 2022
…aml files of on policy algorithm. (#41)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
XuehaiPan added a commit that referenced this pull request Dec 23, 2022
…aml files of on policy algorithm. (#41)

Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants