Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: open pylint in pre-commit #48

Merged
merged 20 commits into from
Dec 18, 2022
Merged

Conversation

zmsn-2077
Copy link
Member

Description

  1. open pylint in pre-commit.yaml

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

Copy link
Collaborator

@friedmainfunction friedmainfunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@zmsn-2077 zmsn-2077 merged commit 44112f8 into PKU-Alignment:dev Dec 18, 2022
@zmsn-2077 zmsn-2077 deleted the dev branch December 18, 2022 13:31
XuehaiPan added a commit that referenced this pull request Dec 22, 2022
Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
XuehaiPan added a commit that referenced this pull request Dec 23, 2022
Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants