Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model-based): fix cap cost bug and lag beta value in cap.yaml #62

Merged
merged 1 commit into from
Jan 1, 2023

Conversation

hdadong
Copy link
Collaborator

@hdadong hdadong commented Jan 1, 2023

Description

fix cap cost bug and lag beta value in cap.yaml, epcosts to epcost

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@hdadong hdadong changed the title fix: epcost2epcost, cap lag beta, planner cost2return fix(model-based): fix cap cost bug and lag beta value in cap.yaml, epcosts to epcost Jan 1, 2023
@hdadong hdadong requested review from zmsn-2077 and Gaiejj and removed request for zmsn-2077 January 1, 2023 02:22
fix: change cap yaml

refactor: delete cap model output

refactor: fix pylint bug

refactor: epcosts to epcost, cap lag beta 1,var^2

fix: cap std, cost2return, lag beta
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zmsn-2077 zmsn-2077 self-requested a review January 1, 2023 07:18
Copy link
Member

@calico-1226 calico-1226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes.

@zmsn-2077 zmsn-2077 changed the title fix(model-based): fix cap cost bug and lag beta value in cap.yaml, epcosts to epcost fix(model-based): fix cap cost bug and lag beta value in cap.yaml Jan 1, 2023
@zmsn-2077 zmsn-2077 merged commit 6651298 into PKU-Alignment:main Jan 1, 2023
Gaiejj pushed a commit to Gaiejj/omnisafe_zjy that referenced this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants