Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new algorithm #80

Merged
merged 5 commits into from
Jan 18, 2023
Merged

feat: add new algorithm #80

merged 5 commits into from
Jan 18, 2023

Conversation

Gaiejj
Copy link
Member

@Gaiejj Gaiejj commented Jan 14, 2023

Description

feat: add new algorithm

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

zmsn-2077
zmsn-2077 previously approved these changes Jan 16, 2023
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After careful review, I agree with these changes.

Copy link
Collaborator

@friedmainfunction friedmainfunction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this pr in detail, approve.

@zmsn-2077 zmsn-2077 self-requested a review January 18, 2023 12:01
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with these changes.

@Gaiejj Gaiejj merged commit 52cb819 into PKU-Alignment:dev Jan 18, 2023
@Gaiejj Gaiejj deleted the dev branch January 18, 2023 12:02
zmsn-2077 pushed a commit that referenced this pull request Feb 5, 2023
Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
@zmsn-2077 zmsn-2077 added new-algorithm Something related to new algorithms algorithm Some issues about algorithm labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Some issues about algorithm new-algorithm Something related to new algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants