Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(safety-gymnasium): code decoupling #81

Merged
merged 12 commits into from
Jan 20, 2023

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Jan 17, 2023

Description

  1. Code decoupling.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@muchvo muchvo changed the title refactor(Safety-Gymnasium): code decoupling refactor(safety-gymnasium): code decoupling Jan 17, 2023
@XuehaiPan XuehaiPan force-pushed the newstruct branch 2 times, most recently from 79245fe to 24c9901 Compare January 18, 2023 12:22
@zmsn-2077 zmsn-2077 self-requested a review January 20, 2023 15:07
@zmsn-2077 zmsn-2077 merged commit 8fa5cac into PKU-Alignment:dev Jan 20, 2023
zmsn-2077 pushed a commit that referenced this pull request Feb 5, 2023
Co-authored-by: Xuehai Pan <XuehaiPan@pku.edu.cn>
@zmsn-2077 zmsn-2077 added enhancement New feature or request codestyle update codestyple labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codestyle update codestyple enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants