Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Request] Support for .huskyrc #355

Closed
daniepetrov opened this issue Dec 10, 2018 · 9 comments
Closed

[Icon Request] Support for .huskyrc #355

daniepetrov opened this issue Dec 10, 2018 · 9 comments

Comments

@daniepetrov
Copy link

Type: filename
Icon Name: husky config
Sample original Icon: this github 🐶 icon is what husky uses
Filenames: .huskyrc, husky.config.js, .huskyrc.json, or .huskyrc.y[a]ml

repo: https://github.com/typicode/husky
PR regarding the new file config: typicode/husky#209

@PKief
Copy link
Owner

PKief commented Dec 12, 2018

The github icon does not fit into the Material Icon Theme at all, so I created another icon.

What do you think about this icon:

husky icon

It also has a great contrast on a white background:

husky icon on a white background

@Alhadis
Copy link

Alhadis commented Dec 14, 2018

You could try the one I drew for Atom's file-icons package:

Figure 1: Husky

Which portrays an actual husky, instead of a terrier. 😉

@PKief
Copy link
Owner

PKief commented Dec 15, 2018

@Alhadis Thank you, that's a great idea, but I was wondering how I can customize this icon to have a nice contrast on a darker background.

On a bright background it looks very good:

husky bright background

But on a dark background it's not nice:

husky dark background

So I tried to add a bright background behind:

husky dark background adjusted

What do you think about that? Do you've any further suggestions?

@Alhadis
Copy link

Alhadis commented Dec 16, 2018

Hey @PKief,

I don't use VSCode, so I don't know if it's possible to support motif-sensitive icon colours (the bright foreground works well, but on a dark background at least). The icon I posted was actually in an "uncoloured" form because each of the icons uses a configurable colour scheme.

So feel free to use any colour you want. 👍

@ghost
Copy link

ghost commented Sep 27, 2019

Any update on this?

@PKief
Copy link
Owner

PKief commented Feb 8, 2020

Finally, I decided to add a husky icon that looks like this:

husky icon

husky icon on light background

@PKief PKief closed this as completed in d98e55d Feb 8, 2020
@lzm0x219
Copy link

Finally, I decided to add a husky icon that looks like this:

husky icon husky icon on light background

It seems that only .huskyrc and .huskyrc.json files are supported, other extensions are not.

@PKief
Copy link
Owner

PKief commented Feb 19, 2020

@vvni The following file names are supported right now:

  • .huskyrc
  • husky.config.js
  • .huskyrc.json
  • .huskyrc.yaml
  • .huskyrc.yml

And there's an open pull request for .huskyrc.js.

Which extensions or file names are missing for you?

@lzm0x219
Copy link

@vvni The following file names are supported right now:

  • .huskyrc
  • husky.config.js
  • .huskyrc.json
  • .huskyrc.yaml
  • .huskyrc.yml

And there's an open pull request for .huskyrc.js.

Which extensions or file names are missing for you?

Ok i have no problem thank you for your answer。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants