Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Husky #766

Closed
jacobbuck opened this issue Oct 18, 2018 · 6 comments
Closed

Husky #766

jacobbuck opened this issue Oct 18, 2018 · 6 comments
Labels
enhancement Feature requests or suggested improvements. new-icon New icons added to the package's icon-font.

Comments

@jacobbuck
Copy link

Would be great to have an icon for husky configuration files: .huskyrc, .huskyrc.json, .huskyrc.js 🐶
@Alhadis
Copy link
Member

Alhadis commented Oct 18, 2018

I was wondering this myself recently. Husky doesn't appear to have a project logo, however. The 🐶 emoji is used, but emoji tend not to make great icons because their appearance varies across systems (not to mention they're impossible to recolour with CSS).

I'm wondering if we shouldn't add a black-and-white emoji font (like Noto Emoji) for cases like this. What do you think?

@Alhadis Alhadis added the icon required Old label used prior to consolidating the package's icon-fonts in different repositories. label Oct 18, 2018
@jacobbuck
Copy link
Author

Yeah I too was thinking a variation of the 🐶 emoji, and Noto Emoji looks good 👌

@jacobbuck
Copy link
Author

Alternatively something like this from Noun Project https://thenounproject.com/search/?q=dog%20face&i=703107

@Alhadis
Copy link
Member

Alhadis commented Oct 19, 2018

I think a drawing of a real husky works better. 👍

Figure 1: Husky

@Alhadis Alhadis added enhancement Feature requests or suggested improvements. new-icon New icons added to the package's icon-font. and removed icon required Old label used prior to consolidating the package's icon-fonts in different repositories. labels Oct 19, 2018
@Alhadis Alhadis mentioned this issue Dec 14, 2018
Closed
@JimiC
Copy link

JimiC commented Mar 23, 2019 •
edited
Loading

@Alhadis Is it OK if we use your husky icon in vscode-icons?

@Alhadis Alhadis reopened this Mar 23, 2019
@Alhadis
Copy link
Member

Alhadis commented Mar 23, 2019

Be my guest! 😉

(and oops, didn't mean to reopen this... stupid phone)

@Alhadis Alhadis closed this as completed Mar 23, 2019
@ericcornelissen ericcornelissen mentioned this issue May 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature requests or suggested improvements. new-icon New icons added to the package's icon-font.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacobbuck @JimiC @Alhadis