Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon & Folder Request] Many Associations, compared with vscode-icons #997

Open
bluedasher13 opened this issue Apr 4, 2021 · 7 comments

Comments

@bluedasher13
Copy link

bluedasher13 commented Apr 4, 2021

I found that vscode-icons has even more icons, but they aren't pretty. (However, they seems has a design rule on config icons.)

Would you add more icons as follows?


(example)

Robots Exclusion Protocol:
robots.txt


(example)

TypeScript config file:
tsconfig.json


(example)

PHP CS Fixer config file:
.php_cs.dist / .php_cs


(example)

PHPUnit config file:
phpunit.xml.dist / phpunit.xml


(example)

Cypress config file:
cypress.json


(example)

Cypress folder:
/cypress/ (e.g. {Project}/cypress/)


(example)

JS Beautifier config file:
.jsbeautifyrc


(example)

Browserslist executable:
browserslist (e.g. {Project}/node_modules/.bin/browserslist/)


(example)

Binary folder:
/.bin/ (e.g. {Project}/node_modules/.bin/)


(example)

Modules folder:
/modules/ (e.g. {VueProject}/src/store/modules/)


(example)

Composer folder:
/composer/ (e.g. {Project}/vendor/bin/composer/)


(example)

Console folder:
/Console/ (e.g. {LaravelProject}/app/Console/)


Vetur config file:
vetur.config.js


Laravel Artisan Console:
artisan


(example)

Laravel compilation entry point:
webpack.mix.js


(example)

lint-staged config file:
.lintstagedrc (JSON or YAML)
.lintstagedrc.json (JSON)
.lintstagedrc.yaml / .lintstagedrc.yml (YAML)
lint-staged.config.js / .lintstagedrc.js / lintstagedrc.cjs (JavaScript)


(example)

Batch & Shell/Bash:
Use different icons to distinguish Windows .bat / .cmd from Unix .sh


And follow a Design Rule on config icons.

For example, vscode-icons use brand logo + gear icon. (postcss.config.js) (vue.config.js)

But Material Icon does not...? (postcss.config.js) (vue.config.js)


vscode-icons samples:

Default:
image

Folder:
image
image
image

File:
image
image
image
image
image
image
image

@mikemykhaylov
Copy link

mikemykhaylov commented Apr 5, 2021

.yarn folder would also be nice

@ghost
Copy link

ghost commented May 26, 2021

I am opening all ten or so icon PRs for you as we speak.

I'm not the repo owner, but for convenience, could you replace the screenshots with the image links? It's a bit exhausting scrolling through them all to check the list

@ghost
Copy link

ghost commented May 26, 2021

@PKief icon for cmd/bat? Maybe exe.svg with the gear from folder-config.svg inside the window

@PKief
Copy link
Owner

PKief commented May 27, 2021

@4086606 Would be great if you could try it out, then we will see if it's fitting into this extension

@ghost
Copy link

ghost commented Jun 2, 2021

As usual, the 16px icon size made this combination more or less impossible. E.g.

We have three options:

If we change the icon, an ideal color would be #d84315 (closest material color to the Microsoft brand color)

@PKief
Copy link
Owner

PKief commented Jun 2, 2021

In my opinion we should leave it as is with the console icon. Not sure how the cogs or windows icon could improve this icon in this case.

@ghost
Copy link

ghost commented Jun 2, 2021

Alright, that's everything in the issue addressed except for this:

And follow a Design Rule on config icons. For example, vscode-icons use brand logo + gear icon. (postcss.config.js) (vue.config.js)
But Material Icon does not...? (postcss.config.js) (vue.config.js)

The two Vue icons are necessary:

  1. Vue components are .vue files
  2. Configs like vue.config.js are for a different purpose

If we only need an icon for config, it doesn't need to follow config pattern.
E.g. webpack nuxt postcss.
For me anyways, adding just makes the icon more complicated to design and see.
Hope this makes sense!

PKief pushed a commit that referenced this issue Jul 9, 2021
* Add PHPUnit icon

* Update size of phpunit icon (References #997)

* Add phpunit-watcher config associations

* Update PHPUnit icon with material color (#1053)

* Remove duplicate Robots.txt entry

* Add .phpunit.result.cache association

* Format fileIcons.ts using Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants