New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPUnit icon #1053
Add PHPUnit icon #1053
Conversation
@4086606 Please also add phpunit-watcher configuration files Ref: https://github.com/spatie/phpunit-watcher#customization @PKief In my opinion this PR is ready to go in the next update. PHPUnit icon looks pretty amazing in my VSCode and many thanks for introducing this SVG @4086606. Closes #1091 |
@4086606 Seems like the branch has a merge conflict still. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice icon, but please take a look at my comment!
@4086606 Yeah this also can be included in the list! |
@PKief PHPUnit is probably ready. Can you please manage sometime to review this PR and get the merge done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks great!
@4086606 Can you also introduce a folder icon for PHPUnit? |
Closes #1091.
Follows the PHPUnit documentation. Requested in #997.