Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPUnit icon #1053

Merged
merged 10 commits into from Jul 9, 2021
Merged

Add PHPUnit icon #1053

merged 10 commits into from Jul 9, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 26, 2021

Closes #1091.
Follows the PHPUnit documentation. Requested in #997.

@shivapoudel
Copy link
Contributor

Good @4086606 this closes #1091

@shivapoudel
Copy link
Contributor

shivapoudel commented Jun 23, 2021

@4086606 Please also add phpunit-watcher configuration files .phpunit-watcher.yml, phpunit-watcher.yml and phpunit-watcher.yml.dist to map with PHPUnit icon.

Ref: https://github.com/spatie/phpunit-watcher#customization

@PKief In my opinion this PR is ready to go in the next update. PHPUnit icon looks pretty amazing in my VSCode and many thanks for introducing this SVG @4086606.

Closes #1091

@shivapoudel
Copy link
Contributor

@4086606 Seems like the branch has a merge conflict still.

@PKief PKief self-requested a review June 24, 2021 05:54
Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice icon, but please take a look at my comment!

icons/phpunit.svg Outdated Show resolved Hide resolved
@ghost ghost requested a review from PKief June 24, 2021 11:33
@shivapoudel
Copy link
Contributor

@PKief @4086606 Everything shaped up and looks nice to ship this in an upcoming version. Waiting for this and the composer icon badly :)

@fell-lucas
Copy link

Hello, is it possible to include .phpunit.result.cache on the list of files to use this icon? It's technically a JSON, but it has no icon for it at the moment.
image

@shivapoudel
Copy link
Contributor

@4086606 Yeah this also can be included in the list!

@shivapoudel
Copy link
Contributor

@PKief PHPUnit is probably ready. Can you please manage sometime to review this PR and get the merge done?

Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great!

@PKief PKief merged commit 24cb253 into PKief:main Jul 9, 2021
@shivapoudel
Copy link
Contributor

@4086606 Can you also introduce a folder icon for PHPUnit?

Ref: https://github.com/wordpress/gutenberg

image

@ghost ghost deleted the phpunit branch April 3, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] Support for phpunit.xml.dist
3 participants