Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TSConfig icons #1066

Merged
merged 1 commit into from May 30, 2021
Merged

Add TSConfig icons #1066

merged 1 commit into from May 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2021

Static configuration files for tsc compiler in TypeScript project (tsconfig, esconfig). Closes #499. Replaces #703.

@PKief PKief self-requested a review May 30, 2021 19:56
Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, your icons are the first I really really like for these files. It will be a big improvement for this extension because the icons were already requested by so many people! Thank you so much :) They look great!

@PKief PKief merged commit 1986882 into PKief:main May 30, 2021
@PKief
Copy link
Owner

PKief commented May 30, 2021

@4086606 You opened a lot of other PRs, and I will also review them, they are of great quality and are also likely to be merged. I just need some time to review them, no worries ;)

@ghost ghost deleted the tsconfig branch May 30, 2021 20:31
@ghost
Copy link
Author

ghost commented May 30, 2021

Thanks & no worries, I'm happy to wait :)

@ghost ghost mentioned this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request] tsconfig.json
1 participant