Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TSC project settings icons #703

Closed
wants to merge 10 commits into from
Closed

Add TSC project settings icons #703

wants to merge 10 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 23, 2020

Replaces #684 - other contributor lost access to their fork.

@PKief PKief self-requested a review May 2, 2020 18:28
@ghost
Copy link
Author

ghost commented May 7, 2020

@PKief the icons I made look nothing like vue-config, so I'll be adjusting them for consistency. I'll make this pull a draft for now, until I get to fix it.

@ghost ghost marked this pull request as draft May 7, 2020 03:29
@ghost ghost marked this pull request as ready for review May 7, 2020 17:15
src/icons/fileIcons.ts Outdated Show resolved Hide resolved
lmn8 and others added 2 commits August 27, 2020 10:04
Fixes #499 and #703 review

Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
@RebeccaStevens
Copy link

Could files in this format also be handled tsconfig.*.json?

@ExE-Boss
Copy link
Contributor

ExE-Boss commented Jan 4, 2021

@RebeccaStevens Unfortunately, VSCode doesn’t currently provide an API for that.

@PKief PKief closed this May 23, 2021
@PKief PKief deleted the branch PKief:master May 23, 2021 16:16
@ghost
Copy link

ghost commented May 25, 2021

There seems to be a lot of closed PRs, is the issue backlog going to be completed or wiped?

@PKief
Copy link
Owner

PKief commented May 25, 2021

The PRs were closed because of the branch renaming. The master branch was renamed to main. And because the maintainer of some branches already deleted their fork, it wasn't possible to change their PR so that it points to the main branch. I see these PRs as outdated.

@ghost
Copy link

ghost commented May 25, 2021

May I refresh these 😅 I will have a batch of PRs open soon

@PKief
Copy link
Owner

PKief commented May 25, 2021

Sure 😃

@ghost ghost mentioned this pull request May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants