Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for craco #1774

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Add icon for craco #1774

merged 3 commits into from
Dec 6, 2022

Conversation

Gu-Miao
Copy link
Contributor

@Gu-Miao Gu-Miao commented Nov 18, 2022

craco is package for customizing configuration of create-react-app without ejecting.

This PR adds icon supporting for configuration files of craco:

  • craco.config.ts
  • craco.config.js
  • craco.config.cjs
  • .cracorc.ts
  • .cracorc.js
  • .cracorc

All the colors in craco.svg is picked from Material Color Converter.

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR. In my opinion the icon looks pretty good. The only thing I'd like to change is to remove the dark background behind the gear wheel. So that we simplify this icon a bit. On dark color themes the dark background of this icon won't be recognized anyways so I think this would improve the icon a bit.

The remaining part (i.e. the gear wheel) can then be increased a bit so that it has the same size as the circular dark background right now.

@dilanx
Copy link

dilanx commented Dec 6, 2022

Here is an official icon with the suggested changes @Gu-Miao @PKief. Please only use this exact file and do not make any modifications to it directly. If you need anything changed, please let me know!

https://github.com/dilanx/craco/blob/main/website/static/img/craco-icon.svg

@Gu-Miao
Copy link
Contributor Author

Gu-Miao commented Dec 6, 2022

Hello @PKief, icon is updated now. Could you review it again?

Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon looks good to me, thank you very much for the changes 👍

@PKief PKief merged commit 54b16c3 into material-extensions:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants