Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon to vscode-material-icon-theme #474

Closed
Gu-Miao opened this issue Nov 22, 2022 · 4 comments
Closed

Add icon to vscode-material-icon-theme #474

Gu-Miao opened this issue Nov 22, 2022 · 4 comments
Labels
feature request New feature or request

Comments

@Gu-Miao
Copy link

Gu-Miao commented Nov 22, 2022

I want to add craco icon support for VSCode using vscode-material-icon-theme. So I created a PR to their repo. I think @dilanx you should know this matter.

And, I need some help with these two things:

  1. I noticed that craco had a Apache License 2.0 LICENSE which has a Trademark use limitation. It says "This license explicitly states that it does NOT grant trademark rights, even though licenses without such a statement probably do not grant any implicit trademark rights." I don't know much about this, will this limitation have any impact on PR?
  2. They gave some adivce to the icon, I think maybe we can discuss about it?
@Gu-Miao Gu-Miao added the feature request New feature or request label Nov 22, 2022
@dilanx
Copy link
Owner

dilanx commented Nov 22, 2022

Great idea, @Gu-Miao.

For the trademark use limitation, it should be fine since the logo is used in a context that directly relates to craco (in this case, it's the config files).

I read the advice and think it's good. I can get an official svg for the icon as they described. I'll comment here once it's ready so you can update your PR with it.

@Gu-Miao
Copy link
Author

Gu-Miao commented Nov 22, 2022

It's very nice to hear that. Looking forward to your icon.😃

@dilanx
Copy link
Owner

dilanx commented Dec 2, 2022

Hey @Gu-Miao. Here's the official icon you can submit in your PR: https://github.com/dilanx/craco/blob/main/website/static/img/craco-icon.svg (raw)

Make sure to use that exact file and do not make any modifications to it, but feel free to let me know if they ask for any more changes. Thanks!

@Gu-Miao
Copy link
Author

Gu-Miao commented Dec 6, 2022

Sorry for the late reply, the icon is nice and I've updated my PR. Thanks a lot for the help!

@dilanx dilanx closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants