You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to add craco icon support for VSCode using vscode-material-icon-theme. So I created a PR to their repo. I think @dilanx you should know this matter.
And, I need some help with these two things:
I noticed that craco had a Apache License 2.0 LICENSE which has a Trademark use limitation. It says "This license explicitly states that it does NOT grant trademark rights, even though licenses without such a statement probably do not grant any implicit trademark rights." I don't know much about this, will this limitation have any impact on PR?
They gave some adivce to the icon, I think maybe we can discuss about it?
The text was updated successfully, but these errors were encountered:
For the trademark use limitation, it should be fine since the logo is used in a context that directly relates to craco (in this case, it's the config files).
I read the advice and think it's good. I can get an official svg for the icon as they described. I'll comment here once it's ready so you can update your PR with it.
I want to add craco icon support for VSCode using
vscode-material-icon-theme
. So I created a PR to their repo. I think @dilanx you should know this matter.And, I need some help with these two things:
The text was updated successfully, but these errors were encountered: