Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Pascal to Vector #1883

Merged
merged 3 commits into from Feb 20, 2023
Merged

Convert Pascal to Vector #1883

merged 3 commits into from Feb 20, 2023

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Feb 20, 2023

Changes proposed:
Updated the Pascal svg file to use a path for drawing its vector. Previously, it was attributed to a font, which attempted to assign the "Roboto" family; this functionality has been broken for a while now, instead falling back to Times New Roman in build previews. As this has been the de-facto behaviour, this commit makes it explicit; changing the vector type to raw paths ensures that it will come out consistently regardless of where this repository is built & what fonts the end-user has currently installed

@PKief PKief self-requested a review February 20, 2023 17:41
Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much to bring my attention to this. I decided to update the icon so that it still has the material look and feel by using the roboto font style. But know fully transformed as vector graph so that it will be shown on all devices correctly.

image

@PKief PKief self-assigned this Feb 20, 2023
@PKief PKief merged commit 91641be into PKief:main Feb 20, 2023
@Repiteo Repiteo deleted the PascalToVector branch February 20, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants