Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon for Tiltfile (https://tilt.dev/) #650

Merged
merged 41 commits into from
May 13, 2020
Merged

Add icon for Tiltfile (https://tilt.dev/) #650

merged 41 commits into from
May 13, 2020

Conversation

Tchoupinax
Copy link
Contributor

Hello,

I am using Tilt (https://tilt.dev/) with VSCode and i would love have icon for Tiltfile (file used by this project).

I made the necessary work. Please tell me if it is not correct. :)

Regards,

@ghost
Copy link

ghost commented Mar 2, 2020 •
edited by ghost
Loading

  • See contribution guidelines. The icon should use material design color like #4CAF50
  • Wouldn't only the "T" be sufficient in icon? It looks strange when I test, and the company uses T for it's logo on Github

@ghost
Copy link

ghost commented Apr 22, 2020 •
edited by ghost
Loading

@Tchoupinax you could use this SVG file I whipped up

@Tchoupinax
Copy link
Contributor Author

Hello @lmn8,

Sorry for my long time answer... and thank you a lot for making the svg great !
Your thinking is great, i did not realize that T will be enought a little icon ^^

I merged master and change icon by yours. Another request change ? :)

Thanks again !

@PKief PKief self-requested a review April 24, 2020 06:34
lmn8 and others added 15 commits May 2, 2020 21:49
Remove Material Design box per PKief/vscode-material-icon-theme/pull/…
61062c6 
…700#discussion_r416770170
@PKief
Fix typo in comment
7f69d99
@PKief
Add imba file icon (Closes #715)
99c21cd
@PKief
Update graphql icon
c6877f5
@hyperupcall
tweak: map jest icon to jest.config.(m|c)js
0214998
@whiitehead
add 'code' to 'folder-src' icon
8ee2ddf
@thmsgbrt
Add GraphQL Resolver icon for Nest
ad5b564
@PKief
Merge pull request #722 from thmsgbrt/master
8d912df 
Add GraphQL Resolver icon for Nest
@PKief
Merge branch 'ml-family' of https://github.com/lmn8/vscode-material-i…
9a93036 
…con-theme into lmn8-ml-family
@PKief
Slightly decrease size of icon
f23c8c6
@PKief
Merge pull request #700 from lmn8/ml-family
d2fd6b9 
Add Standard ML family icon
@PKief
Merge pull request #720 from whiitehead/master
4e39b88 
add 'code' to 'folder-src' icon
@PKief
Merge pull request #718 from eankeen/feat/icon-jest-modules
8a2a4a0 
add jest icons for jest.config.(m|c)js
@PKief
Merge branch 'master' of https://github.com/Tchoupinax/vscode-materia…
7f3d02f 
…l-icon-theme into Tchoupinax-master
@PKief
Rename tilt icon
3bd5068
PKief
PKief approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@Tchoupinax
Copy link
Contributor Author

Nice ! o/

@PKief PKief merged commit 47b4f96 into material-extensions:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tchoupinax @PKief @hyperupcall @whiitehead @thmsgbrt