Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added apollo folder icon #793

Merged
merged 14 commits into from Aug 21, 2020
Merged

Added apollo folder icon #793

merged 14 commits into from Aug 21, 2020

Conversation

Deckstar
Copy link
Contributor

@Deckstar Deckstar commented Aug 2, 2020

Adding icons for an Apollo folder, because there is currently only an icon for and Apollo config file.

I love this extension very much, and I hope this little contribution can be useful! :)

Resolves #798

Copy link
Owner

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nearly no contrast between the default dark background of VS Code and the apollo folder icon. This is why is usually pick a lighter color for the icons:

proposed apollo icon

I slightly changed the colors of all apollo icons to be more consistent:

updated apollo icon

@Deckstar
Copy link
Contributor Author

Ah I see :) Sorry about that!

Anyway, the purple version looks fantastic. Thanks a lot!

@PKief PKief merged commit dc2bb0d into PKief:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Folder Icon Request] Apollo folder
4 participants