Add Devlink functional tests #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiyBoikoPLV
requested changes
Apr 14, 2023
...sTestbed/src/dent_os_testbed/test/test_suite/functional/devlink/test_devlink_single_block.py
Outdated
Show resolved
Hide resolved
...sTestbed/src/dent_os_testbed/test/test_suite/functional/devlink/test_devlink_single_block.py
Outdated
Show resolved
Hide resolved
DentOS_Framework/DentOsTestbed/src/dent_os_testbed/utils/test_utils/tc_flower_utils.py
Outdated
Show resolved
Hide resolved
AndriyLozovyyPLV
force-pushed
the
devlink_tc_wip
branch
from
eec6fae
to
db7e82e
Compare
yuriilisovskyi
approved these changes
Apr 21, 2023
| @@ -116,5 +117,6 @@ | |||
| 'suite_functional_qos', | |||
| 'suite_functional_ipv4', | |||
| 'suite_functional_ipv6', | |||
| 'suite_functional_l1'] | |||
| 'suite_functional_l1', | |||
| 'suite_functional_devlink'] | |||
There was a problem hiding this comment.
Add comma at the end of line and move ] to next line. It will be easier to merge conflicts in future
| Randomize applying rule by choosing src/dst field | ||
| Args: | ||
| tc_rule (dict): Dict with tc_rule | ||
| rule_selectors (dict): Dict with rule selectros |
AndriyLozovyyPLV
force-pushed
the
devlink_tc_wip
branch
from
db7e82e
to
0970ac5
Compare
| rule = {'action': {'trap': '', | ||
| 'police': {'rate': f'{policer_rate}bps', 'burst': policer_rate + 1000, | ||
| 'conform-exceed': '', 'drop': ''}}, | ||
| 'want_ip': True if traffic in ['l3', 'l4'] else False, |
There was a problem hiding this comment.
Suggested change
| 'want_ip': True if traffic in ['l3', 'l4'] else False, | |
| 'want_ip': traffic in ['l3', 'l4'], |
| 'want_ip': want_ip, | ||
| 'want_port': want_port, | ||
| 'want_tcp': choice([True, False]) if want_port else False, | ||
| 'want_vlan_ethtype': True if want_ip and want_vlan else False} |
There was a problem hiding this comment.
Suggested change
| 'want_vlan_ethtype': True if want_ip and want_vlan else False} | |
| 'want_vlan_ethtype': want_ip and want_vlan} |
| @@ -126,14 +126,15 @@ async def tcutil_cleanup_tc_rules(dent_dev, swp_tgen_ports, swp_tc_rules): | |||
|
|
|||
|
|
|||
| def tcutil_tc_rules_to_tgen_streams(swp_tc_rules, streams=None, start=0, cnt=None, | |||
| frame_rate_pps=10, frame_size=256): | |||
| frame_rate_pps=10, frame_size=256, frame_rate_type=None): | |||
There was a problem hiding this comment.
Suggested change
| frame_rate_pps=10, frame_size=256, frame_rate_type=None): | |
| frame_rate_pps=10, frame_size=256, frame_rate_type='pps_rate'): |
Closed
AndriyLozovyyPLV
force-pushed
the
devlink_tc_wip
branch
from
0970ac5
to
f121a61
Compare
Signed-off-by: Andriy Lozovyy <andriy.lozovyy@plvision.eu>
AndriyLozovyyPLV
force-pushed
the
devlink_tc_wip
branch
from
f121a61
to
fa7b9c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Devlink functional test cases:
Depends on: #109