Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test policer functional tests #92

Closed
wants to merge 1 commit into from
Closed

Test policer functional tests #92

wants to merge 1 commit into from

Conversation

StepanVovkPLV
Copy link
Collaborator

@StepanVovkPLV StepanVovkPLV commented Apr 4, 2023 •
edited
Loading

Adds 2 tests:

- test_policer_basic_functionality
- test_policer_rules_priority
- test_policer_rate_config

Depend on #110 , #109

yuriilisovskyi
yuriilisovskyi requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@yuriilisovskyi yuriilisovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash the commits and sign them

...ntOsTestbed/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_ipv4_func.py Outdated Show resolved Hide resolved
...ntOsTestbed/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_ipv4_func.py Outdated Show resolved Hide resolved
DentOS_Framework/DentOsTestbed/src/dent_os_testbed/utils/test_utils/tc_flower_utils.py Outdated Show resolved Hide resolved
@StepanVovkPLV StepanVovkPLV force-pushed the test_policer_func_ipv4 branch 5 times, most recently from 8a7f3fe to e0e62b0 Compare April 24, 2023 08:26
@StepanVovkPLV StepanVovkPLV force-pushed the test_policer_func_ipv4 branch 3 times, most recently from f6b1d73 to 5dbc989 Compare April 25, 2023 08:22
SerhiyBoikoPLV
SerhiyBoikoPLV requested changes Apr 25, 2023
View reviewed changes
...d/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_basic_functionality.py
tgen_utils_setup_streams,
tgen_utils_start_traffic,
tgen_utils_stop_traffic,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space here, add space after )

...d/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_basic_functionality.py Outdated Show resolved Hide resolved
...d/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_basic_functionality.py Show resolved Hide resolved
...d/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_basic_functionality.py Outdated Show resolved Hide resolved
...d/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_basic_functionality.py Outdated Show resolved Hide resolved
...tOsTestbed/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_rate_units.py Show resolved Hide resolved
...tOsTestbed/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_rate_units.py Show resolved Hide resolved
...tOsTestbed/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_rate_units.py Outdated Show resolved Hide resolved
...estbed/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_rules_priority.py Show resolved Hide resolved
...estbed/src/dent_os_testbed/test/test_suite/functional/policer/test_policer_rules_priority.py
if qdisc_type == 'port':
for port in port_with_rule:
tc_rule_1['dev'] = port
out = await TcFilter.add(input_data=[{dent: [tc_rule_1]}])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list comprehension

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@github-actions

This comment was marked as resolved.

Sign in to view
1 similar comment
@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions

This comment was marked as resolved.

Sign in to view
@StepanVovkPLV StepanVovkPLV force-pushed the test_policer_func_ipv4 branch 2 times, most recently from a5b4fa5 to 4225e79 Compare April 25, 2023 14:09
@StepanVovkPLV
Add policer tests
fad110a 
Signed-off-by: Stepan Vovk <stepan.vovk@plvision.eu>
SerhiyBoikoPLV
SerhiyBoikoPLV requested changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@SerhiyBoikoPLV SerhiyBoikoPLV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@StepanVovkPLV
Copy link
Collaborator Author

Closed in favor of this #120

@StepanVovkPLV StepanVovkPLV deleted the test_policer_func_ipv4 branch May 2, 2023 06:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiyBoikoPLV SerhiyBoikoPLV SerhiyBoikoPLV requested changes

@yuriilisovskyi yuriilisovskyi Awaiting requested review from yuriilisovskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StepanVovkPLV @SerhiyBoikoPLV @yuriilisovskyi