-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vep #22
Vep #22
Conversation
Quick question, Why not make your life easier and use the bioconda version of VEP + container? Cheers |
Thanks @matthdsm, that's exactly what I was looking for! I think this will need some extra features to janis-core to ensure correct binding of plugin dependencies while creating the command line, but the bioconda docker is exactly what I wanted, and you built it! |
conda has images for virtually every piece of software registered there, so it's an easy to use resource (cfr my PR, also conda dockers). Cheers |
Yeah agreed, my first port of call is usually the original vendor for a container, and then biocontainers. But the biocontainers is definitely more what we want here. |
# Conflicts: # janis_bioinformatics/tools/ensembl/vep/v98_3/base.py
So the plugins have always been a bit of a complication, but now with expressions (https://github.com/PMCC-BioinformaticsCore/janis-core/pull/10/files), we're one step closer to this being merged. The syntax for a plugin looks like the following: ToolArgument(
If(
IsDefined(InputSelector("caddReference")),
[
"--plugin",
"CADD," + JoinOperator(InputSelector("caddReference"), ","),
],
None,
)
), I'm waiting on clarifying the WDL separator function (and obviously the PR expression to merge) and then I can test this a bit more. The reality is every plugin effectively needs to be added to the wrapper separately, not a big deal but something to keep in mind. I've added one (1) thing for a custom plugin, that block could be duplicated but is a little hard to make generic (feedback welcome)! |
This requires PMCC-BioinformaticsCore/janis-core#10 to be completed before this can be merged. |
@rlupat this is probably ready to merge with janis-core changes already in master and released. |
Adding Vep to Janis-bioinf. This is a bit complicated and may require some rework for plugins.