Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build note for Nim 2.0.0 #165

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

woolsweater
Copy link
Contributor

When building with v2 of the language repo, nimsuggest wants to import sha1 from under the 'dist/' directory: https://github.com/nim-lang/Nim/blob/v2.0.0/nimsuggest/nimsuggest.nim#L19 That directory is generated in the course of building the main Nim repository; without it nimsuggest will not build and therefore building nimlsp will also fail.

Nimsuggest wants to import `sha1` from under the 'dist/' directory:
https://github.com/nim-lang/Nim/blob/v2.0.0/nimsuggest/nimsuggest.nim#L19
which is generated in the course of building the main Nim repository;
without it `nimsuggest` will not build and therefore building `nimlsp`
will also fail.
@PMunch PMunch merged commit 0aeaa76 into PMunch:master Sep 19, 2023
@PMunch
Copy link
Owner

PMunch commented Sep 19, 2023

Hmm, what a strange bug.. We should look into which part of build_all actually does this step so that we can potentially do it ourselves.

@Karrq
Copy link

Karrq commented Nov 12, 2023

I just incurred in this issue when building nimble via nix for nim2 (since the nix package doesn't build nimble from nim sources).
I also noticed dist wasn't part of the installed package, and I found that niminst doesn't add the dist folder to the list of folders to copy over in the final install.sh, probably because it's just in the "[Other]" section of installer.ini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants