POUNDERS/MATLAB GitHub Testing Action

[jared321]

The work associated with the branch has been finished. The following will be done as part of a self-review of the PR

• Review of all changes
• Confirm that both layers of tox tools are still functioning correctly.
• Confirm that all MATLAB tests are documented with correct setup information.
• Confirm that each MATLAB test can be run independently.
• Confirm that all MATLAB tests leave the path unaltered if successful.
• Confirm that all MATLAB tests can be run from different locations.
• Confirm that executing runtests in MATLAB from the clone's root will run all MATLAB tests in repo and that a single, full coverage report can be generated.
• Break Python and MATLAB tests and confirm errors reported with tox, local MATLAB testing, and GH actions.
• Intentionally inject formatting error to see that newly modernized flake8 and black actions fail with useful information.
• Alter code coverage for both Python and MATLAB and confirm changes with tox, local MATLAB testing, GH actions, and CodeCov.
• Download and sanity check coverage report artifacts.
• Review action logs for correctness.

All manual MATLAB testing was done on GCE/compute-004 with MATLAB R2023b.

@jmlarson1
The miss_hit action presently logs the following without the action indicating failure

In pounders/m/general_h_funs/emittance_combine.m, line 1
| function [G, H] = emittance(Cres, Gres, Hres)
|                   ^^^^^^^^^ check (low): function name does not match the filename emittance_combine [filename_primary_entity_name]
MISS_HIT Lint Summary: 57 file(s) analysed, 1 check(s)

@jmlarson1 @mmenickelly Can you both please review this work.

[coveralls]

Pull Request Test Coverage Report for Build 8854673898

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+4.4%) to 100.0%

---

Totals
Change from base Build 8787010077:	4.4%
Covered Lines:	15
Relevant Lines:	15

---

💛 - Coveralls

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[jmlarson1]

@jared321 I have resolved the issue

In pounders/m/general_h_funs/emittance_combine.m, line 1
| function [G, H] = emittance(Cres, Gres, Hres)
|                   ^^^^^^^^^ check (low): function name does not match the filename emittance_combine [filename_primary_entity_name]
MISS_HIT Lint Summary: 57 file(s) analysed, 1 check(s)

I also have resolved issue #151

[jmlarson1]

@jared321 Is it possible to see which files are covered at what levels? All I see is 93.78% here:
https://app.codecov.io/gh/POptUS/IBCDFO/pull/146?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=POptUS

Am I missing something?

[jared321]

@jmlarson1 I believe that the limited amount of information on that page is due to the fact that CodeCov is being introduced on this branch. As mentioned above and on that page, more information should be shown after this branch makes its way into main (TBC).

I am able to see the breakdown after poking around and looking at my branch:
https://app.codecov.io/gh/POptUS/IBCDFO/tree/145MatlabCI

[wildsm]

As discussed, we should hold off on this until the cell2mat(allcomb(-)) have been eliminated.

This will mean that allcomb is not referenced in the readme and will allow the tests/actions to complete without the additional external dependency.