Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to toggle odom and alias tf (continued from #92) #149

Merged
merged 6 commits into from
Jul 14, 2023

Conversation

willcbaker
Copy link
Contributor

@willcbaker willcbaker commented Apr 26, 2023

See #92

This feature introduces parameters to toggle on/off publishing of TFs to avoid tf conflicts from other sources.

For examples:

if this were used as an odometry signal in http://wiki.ros.org/robot_localization you need to toggle off the odom->base_link tf
if not using base link frame_id but the tf already exists (e.g. from robot_state_publisher) do not publish an identity transform

Copy link
Contributor Author

@willcbaker willcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean whitespace

@sumanthrao1997
Copy link
Contributor

Thanks for this commit, it was useful to me.

@nachovizzo
Copy link
Collaborator

@willcbaker would you mind giving me access to your branch so I can directly make the changes there?

@nachovizzo nachovizzo merged commit 05f08cf into PRBonn:main Jul 14, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants