Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Restore ReprocessBlocks in main.cpp / Rename DisconnectBlocksAndReprocess to DisconnectBlocks #183

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

lyricidal
Copy link

Chengeset:

  • move ProcessSpork, GetSporkValue, IsSporkActive, ExecuteSpork and mapSporksActive to CSporkManager
  • move Sign, CheckSignature, Relay to CSporkMessage
  • move ReprocessBlocks out of sporks to main.cpp / rename DisconnectBlocksAndReprocess to DisconnectBlocks
  • rename SporkKey to SporkPubKey
  • bugfix: only set strMasterPrivKey if spork signature produced by that key was verified successfully
  • few log format changes, cleaned up includes
  • Protect CSporkManager with critical section
  • bugfix: do not accept sporks with nTimeSigned way too far into the future
  • remove unused sporks: 7, 11, 12
  • Refactor code to get rid of repeated if/else blocks (introduce CSporkDef)

Mostly based off of:

Cherry picked from PIVX-Project/PIVX#1000 as these functions will be useful in the future.

ReprocessBlocks function was in spork.cpp which was eliminated before the code was forked.

@lyricidal lyricidal added the Upstream Upstream backports/fixes label Jan 13, 2022
@lopeed lopeed merged commit d5939c1 into develop Jan 13, 2022
@lopeed lopeed deleted the cherry-pick branch January 13, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream Upstream backports/fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants