Refactor/fix spork #922
Merged
Refactor/fix spork #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move ProcessSpork, GetSporkValue, IsSporkActive, ExecuteSpork and mapSporksActive to CSporkManager - move Sign, CheckSignature, Relay to CSporkMessage - move ReprocessBlocks out of sporks to main.cpp / rename DisconnectBlocksAndReprocess to DisconnectBlocks - rename SporkKey to SporkPubKey - bugfix: only set strMasterPrivKey if spork signature produced by that key was verified successfully - few log format changes, cleaned up includes
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Sep 26, 2019
84930b9 [Trivial] Align the format of the log messages in kernel.cpp (random-zebra) faa9090 [Trivial] rename DisconnectBlocks argument for consistency (random-zebra) 3df34c6 [Spork] fix CSporkManager maps (random-zebra) 3ec2f61 [Tests] spork functional test: check spork value after node restart (random-zebra) 8f6d6e1 [Core] ReprocessBlocks: adjust to PIVX blocktime (random-zebra) 50bfe70 Fix spork RPC to use new spork defs (random-zebra) fd05256 [Spork] Make CSporkMessage::vchSig private (random-zebra) 3709ba8 [Spork] Introduce CSporkDef and remove if/else blocks (random-zebra) 4df1046 [Spork] Define SporkId enum (with its serialization) (random-zebra) 41effbf [Spork] Remove unused SPORK_11 and SPORK_12 (random-zebra) 459e41a [Spork] Remove unused SPORK_7_MASTERNODE_SCANNING (random-zebra) 5124b89 [Spork] Do not accept sporks signed too far into the future (random-zebra) 806f607 [Spork] CSporkManager class serialization (random-zebra) cd33d3c [Spork] Protect CSporkManager with critical section (random-zebra) c41dd7c [Refactor] refactor/fix CSporkManager and CSporkMessage classes (random-zebra) ab603a1 [Refactor] rename SporkKey to SporkPubKey (random-zebra) Pull request description: Chengeset: - move ProcessSpork, GetSporkValue, IsSporkActive, ExecuteSpork and mapSporksActive to CSporkManager - move Sign, CheckSignature, Relay to CSporkMessage - move ReprocessBlocks out of sporks to main.cpp / rename DisconnectBlocksAndReprocess to DisconnectBlocks - rename SporkKey to SporkPubKey - bugfix: only set strMasterPrivKey if spork signature produced by that key was verified successfully - few log format changes, cleaned up includes - Protect CSporkManager with critical section - bugfix: do not accept sporks with nTimeSigned way too far into the future - remove unused sporks: 7, 11, 12 - Refactor code to get rid of repeated if/else blocks (introduce CSporkDef) Mostly based off of: - dashpay#922 - dashpay#2213 - dashpay#2578 - dashpay#2607 - dashpay#2946 ACKs for top commit: Warrows: ACK 84930b9 furszy: ACK [`84930b9`](84930b9) Tree-SHA512: 17f923e85371c444aa2092b12b025db1894c55679549d1a6a3d9f4525f8d78e9225d3f05e296643e7c79d02414bef1613f14d441901dc5f52531c3f30dce357c
akshaynexus
added a commit
to dogecash/dogecash-old
that referenced
this pull request
Oct 27, 2019
84930b9 [Trivial] Align the format of the log messages in kernel.cpp (random-zebra) faa9090 [Trivial] rename DisconnectBlocks argument for consistency (random-zebra) 3df34c6 [Spork] fix CSporkManager maps (random-zebra) 3ec2f61 [Tests] spork functional test: check spork value after node restart (random-zebra) 8f6d6e1 [Core] ReprocessBlocks: adjust to PIVX blocktime (random-zebra) 50bfe70 Fix spork RPC to use new spork defs (random-zebra) fd05256 [Spork] Make CSporkMessage::vchSig private (random-zebra) 3709ba8 [Spork] Introduce CSporkDef and remove if/else blocks (random-zebra) 4df1046 [Spork] Define SporkId enum (with its serialization) (random-zebra) 41effbf [Spork] Remove unused SPORK_11 and SPORK_12 (random-zebra) 459e41a [Spork] Remove unused SPORK_7_MASTERNODE_SCANNING (random-zebra) 5124b89 [Spork] Do not accept sporks signed too far into the future (random-zebra) 806f607 [Spork] CSporkManager class serialization (random-zebra) cd33d3c [Spork] Protect CSporkManager with critical section (random-zebra) c41dd7c [Refactor] refactor/fix CSporkManager and CSporkMessage classes (random-zebra) ab603a1 [Refactor] rename SporkKey to SporkPubKey (random-zebra) Pull request description: Chengeset: - move ProcessSpork, GetSporkValue, IsSporkActive, ExecuteSpork and mapSporksActive to CSporkManager - move Sign, CheckSignature, Relay to CSporkMessage - move ReprocessBlocks out of sporks to main.cpp / rename DisconnectBlocksAndReprocess to DisconnectBlocks - rename SporkKey to SporkPubKey - bugfix: only set strMasterPrivKey if spork signature produced by that key was verified successfully - few log format changes, cleaned up includes - Protect CSporkManager with critical section - bugfix: do not accept sporks with nTimeSigned way too far into the future - remove unused sporks: 7, 11, 12 - Refactor code to get rid of repeated if/else blocks (introduce CSporkDef) Mostly based off of: - dashpay/dash#922 - dashpay/dash#2213 - dashpay/dash#2578 - dashpay/dash#2607 - dashpay/dash#2946 ACKs for top commit: Warrows: ACK 84930b9 furszy: ACK [`84930b9`](PIVX-Project/PIVX@84930b9) Tree-SHA512: 17f923e85371c444aa2092b12b025db1894c55679549d1a6a3d9f4525f8d78e9225d3f05e296643e7c79d02414bef1613f14d441901dc5f52531c3f30dce357c
akshaynexus
added a commit
to dogecash/dogecash-old
that referenced
this pull request
Oct 27, 2019
84930b9 [Trivial] Align the format of the log messages in kernel.cpp (random-zebra) faa9090 [Trivial] rename DisconnectBlocks argument for consistency (random-zebra) 3df34c6 [Spork] fix CSporkManager maps (random-zebra) 3ec2f61 [Tests] spork functional test: check spork value after node restart (random-zebra) 8f6d6e1 [Core] ReprocessBlocks: adjust to PIVX blocktime (random-zebra) 50bfe70 Fix spork RPC to use new spork defs (random-zebra) fd05256 [Spork] Make CSporkMessage::vchSig private (random-zebra) 3709ba8 [Spork] Introduce CSporkDef and remove if/else blocks (random-zebra) 4df1046 [Spork] Define SporkId enum (with its serialization) (random-zebra) 41effbf [Spork] Remove unused SPORK_11 and SPORK_12 (random-zebra) 459e41a [Spork] Remove unused SPORK_7_MASTERNODE_SCANNING (random-zebra) 5124b89 [Spork] Do not accept sporks signed too far into the future (random-zebra) 806f607 [Spork] CSporkManager class serialization (random-zebra) cd33d3c [Spork] Protect CSporkManager with critical section (random-zebra) c41dd7c [Refactor] refactor/fix CSporkManager and CSporkMessage classes (random-zebra) ab603a1 [Refactor] rename SporkKey to SporkPubKey (random-zebra) Pull request description: Chengeset: - move ProcessSpork, GetSporkValue, IsSporkActive, ExecuteSpork and mapSporksActive to CSporkManager - move Sign, CheckSignature, Relay to CSporkMessage - move ReprocessBlocks out of sporks to main.cpp / rename DisconnectBlocksAndReprocess to DisconnectBlocks - rename SporkKey to SporkPubKey - bugfix: only set strMasterPrivKey if spork signature produced by that key was verified successfully - few log format changes, cleaned up includes - Protect CSporkManager with critical section - bugfix: do not accept sporks with nTimeSigned way too far into the future - remove unused sporks: 7, 11, 12 - Refactor code to get rid of repeated if/else blocks (introduce CSporkDef) Mostly based off of: - dashpay/dash#922 - dashpay/dash#2213 - dashpay/dash#2578 - dashpay/dash#2607 - dashpay/dash#2946 ACKs for top commit: Warrows: ACK 84930b9 furszy: ACK [`84930b9`](PIVX-Project/PIVX@84930b9) Tree-SHA512: 17f923e85371c444aa2092b12b025db1894c55679549d1a6a3d9f4525f8d78e9225d3f05e296643e7c79d02414bef1613f14d441901dc5f52531c3f30dce357c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ProcessSpork,GetSporkValue,IsSporkActive,ExecuteSporkandmapSporksActivetoCSporkManagerSign,CheckSignature,RelaytoCSporkMessageReprocessBlocksout of sporks to main.cpp / renameDisconnectBlocksAndReprocesstoDisconnectBlocksSporkKeytoSporkPubKeystrMasterPrivKeyif spork signature produced by that key was verified successfullyNote: diff looks a bit messy - I moved things around to group functions in .h and .cpp the same way