You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Since moving Build-Bicep to use DLL instead of bicep.exe we need to have the compiled DLL files in the assets folder.
We have the DLLs in question set as required in the module manifest (psd1), but this is not a check that they actually exist.
This makes it so that you may actually import the module even if the DLL files are missing, which leads to all kinds of interesting errors.
This may not be a problem for installations from the gallery
We will, eventually, set up a proper build step to 'compile' the module for release, and in that step make sure that the required DLLs are part of the nuget package in the PowerShell Gallery,
but the problem will still be a part of running the module from the repo as we don't want compiled DLLs here.
Describe the solution you'd like
If the module is loaded without the DLLs in their assigned location either:
throw an error or warning when importing the module such as 'failed to load DLL files'
or
throw a better error in all functions that requires the DLLs to function
Additional context
I am actually more leaning to solution number 2 as of now. We have the lifecycle CmdLets (Install, Uninstall, Update) that doesn't rely on DLL files. If a user uses the module for bicep.exe lifecycle management it should be easy to do so in any scenario.
The text was updated successfully, but these errors were encountered:
We can also add a section in docs about how to install the module using the latest code by downloading the code and execute the downloadAssemblies.ps1 script to download all assemblies needed.
Closing this. Have added instructions to CONTRIBUTING.md regarding how to clone and download the dependencies. And when the module can't be loaded without BicepNet starting with version 2.0.
Is your feature request related to a problem? Please describe.
Since moving Build-Bicep to use DLL instead of bicep.exe we need to have the compiled DLL files in the assets folder.
We have the DLLs in question set as required in the module manifest (psd1), but this is not a check that they actually exist.
This makes it so that you may actually import the module even if the DLL files are missing, which leads to all kinds of interesting errors.
This may not be a problem for installations from the gallery
We will, eventually, set up a proper build step to 'compile' the module for release, and in that step make sure that the required DLLs are part of the nuget package in the PowerShell Gallery,
but the problem will still be a part of running the module from the repo as we don't want compiled DLLs here.
Describe the solution you'd like
If the module is loaded without the DLLs in their assigned location either:
or
Additional context
I am actually more leaning to solution number 2 as of now. We have the lifecycle CmdLets (Install, Uninstall, Update) that doesn't rely on DLL files. If a user uses the module for bicep.exe lifecycle management it should be easy to do so in any scenario.
The text was updated successfully, but these errors were encountered: