Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown update for -ProgressAction and missing command #330

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

PalmEmanuel
Copy link
Member

@PalmEmanuel PalmEmanuel commented Jan 9, 2024

Contributing a Pull Request

Overview/Summary

Updates markdown documentation to take the new common parameter -ProgressAction into account, and adds markdown help for new command Get-UsedModulesInBicepFile.

Note: Some whitespace is changed around in the parameter blocks because of the fix script I use to manually move the parameter -ProgressAction.

This PR fixes

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing.
  • Verified build scripts work.
  • Updated relevant and associated documentation.

@PalmEmanuel
Copy link
Member Author

Some files had powershell as the language for the code blocks. If we want to keep that I can go through all of them and add it, but the next time we run the platyPS update in full it's going to overwrite it again.

@PalmEmanuel PalmEmanuel added documentation Improvements or additions to documentation updatedDocs Used for automatic release notes and removed documentation Improvements or additions to documentation labels Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

Linux Test Results

  2 files  ±0  116 suites  ±0   33s ⏱️ -1s
206 tests ±0  206 ✅ ±0  0 💤 ±0  0 ❌ ±0 
412 runs  ±0  412 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4d3f389. ± Comparison against base commit 80ccd21.

♻️ This comment has been updated with latest results.

@StefanIvemo
Copy link
Member

Some files had powershell as the language for the code blocks. If we want to keep that I can go through all of them and add it, but the next time we run the platyPS update in full it's going to overwrite it again.

We added that to make the docs look better on github. But I guess that it's not that common to go there to read it. I can live without the highlighting to simplify managing docs.

@bjompen
Copy link
Collaborator

bjompen commented Jan 10, 2024

Was bored. Tried to catch up with y'alls sudden development adventures yesterday. Fixed the merge conflict 😁

Copy link
Member

@SimonWahlin SimonWahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@SimonWahlin SimonWahlin merged commit f3c1a25 into main Jan 11, 2024
7 checks passed
@SimonWahlin SimonWahlin deleted the markdown-update-pwsh7.4 branch January 11, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
updatedDocs Used for automatic release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants