Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve original dimensions in user logos #303

Open
MaxGhenis opened this issue Mar 6, 2024 · 5 comments
Open

Preserve original dimensions in user logos #303

MaxGhenis opened this issue Mar 6, 2024 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@MaxGhenis
Copy link
Contributor

e.g. these get scrunched

https://pslmodels.org/users.html

image
@jdebacker
Copy link
Member

Good catch, @MaxGhenis.

@fox8090 Any suggestions on how this could be done?

@jdebacker jdebacker added bug Something isn't working help wanted Extra attention is needed labels Mar 10, 2024
@jdebacker
Copy link
Member

This also happens on the Catalog page. E.g.,
Screenshot 2024-03-09 at 10 44 47 PM

@jdebacker
Copy link
Member

Re the news outlets, which seem to be affected the most: we could pull alternative logos for those with the longer names. E.g.,
image

and

image

and

image

@jdebacker
Copy link
Member

PR #317 makes progress on this for the model catalog cards.

Something similar could be adapted to user logos, although in that case, perhaps setting a maximum for height of the image makes more sense.

@fox8090
Copy link
Contributor

fox8090 commented Mar 30, 2024

Implemented enhancements and fixes addressing this issue. Details and discussion can be found in PR #321.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants