Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy_current_law.json needs to be updated with 2018 parameters #1694

Closed
MattHJensen opened this issue Nov 21, 2017 · 10 comments
Closed

policy_current_law.json needs to be updated with 2018 parameters #1694

MattHJensen opened this issue Nov 21, 2017 · 10 comments

Comments

@MattHJensen
Copy link
Contributor

https://www.irs.gov/pub/irs-drop/rp-17-58.pdf

See last year's update: #1169

@martinholmer
Copy link
Collaborator

martinholmer commented Nov 24, 2017

@MattHJensen asked for help in adding to policy_current_law.json the values of tax policy parameters for 2018.

I know IRS has published 2018 values, but isn't this request pre-mature given that TCJA may change many 2018 values?

@MaxGhenis
Copy link
Contributor

MaxGhenis commented Dec 19, 2017

If TCJA goes into effect, will this be irrelevant?

On a related note: if TCJA goes into effect, will there be a way to access current policy? I suspect people will continue to be interested in analyzing TCJA relative to current/previous policy. One option could be adding current policy as a "reform" to the reforms folder. Happy to file a separate issue on this.

@martinholmer
Copy link
Collaborator

@MaxGhenis said:

On a related note: if TCJA goes into effect, will there be a way to access current policy? I suspect people will continue to be interested in analyzing TCJA relative to current/previous policy. One option could be adding current policy as a "reform" to the reforms folder.

We haven't discussed this, but passage of the TCJA bill into law will, of course, change the meaning of "current-law policy" and there will probably be a major revision to the contents of the taxcalc/reforms directory. One of the first new reforms to be added would probably be prior_law_policy.json, which would reform the TCJA current-law policy back to the pre-TCJA policy.

@MattHJensen
Copy link
Contributor Author

Perhaps 2017_law_policy.json or similar, as there may be many "prior laws" in the lifetime of Tax-Calculator.

@martinholmer
Copy link
Collaborator

martinholmer commented Jan 2, 2018

@MattHJensen said in issue #1694 entitled "current_law_policy.json needs to be updated with 2018 parameters":

https://www.irs.gov/pub/irs-drop/rp-17-58.pdf

See last year's update: #1169

Just to confirm my understanding of this issue, the 2018 values in the cited IRS publication are no longer correct given the passage of TCJA. Right?

I assume IRS will soon publish a new document that has 2018 values for the now chained-CPI indexed parameters whose amounts were not explicitly changed by TCJA. We can do this update when that new document is published.

@MattHJensen
Copy link
Contributor Author

Just to confirm my understanding of this issue, the 2018 values in the cited IRS publication are no longer correct given the passage of TCJA. Right?

That's correct.

I assume IRS will soon publish a new document that has 2018 values for the now chained-CPI indexed parameters whose amounts were not explicitly changed by TCJA. We can do this update when that new document is published.

The IRS just published the new parameters, which are explained and linked to from this KPMG report.

@MattHJensen
Copy link
Contributor Author

This update will be easier when the 2018 forms are published. Currently a draft 1040 is out, but I believe it is being revised.

@martinholmer martinholmer changed the title current_law_policy.json needs to be updated with 2018 parameters policy_current_law.json needs to be updated with 2018 parameters Oct 5, 2018
@martinholmer
Copy link
Collaborator

@Peter-Metz, as I said in this comment a few days ago, your help in resolving issue #1694 would be much appreciated. I've tried to provide more guidance for your work by adding a FAQ on the policy parameter updating process in issue #2183. You can open a pull request now that consists of several small commits, each one of which contains changes in the policy_current_law.json file associated with a single final 2018 IRS form/instructions. So, for example, the first commit would contain just the 2018 values for parameters on the 2018 Form 1040 or in the Form 1040 instructions. The second commit would contain just the 2018 values for parameters on the 2018 Form 2441 or in the Form 2441 instructions. And so forth, until all the parameters are updated with actual 2018 values.

As you go about this work, you can test the coding style of the revised policy_current_law.json file, using this command:

$ pycodestyle --ignore=E501,E121 taxcalc/policy_current_law.json

Also, as you commit the changes associated with each IRS form/instructions, be sure to edit the pull request comment to provide a URL for the IRS PDF file that contains the form and for the IRS PDF file that contains the form instructions.

If you have any questions about how to proceed, pose them here in issue #1694.

@MattHJensen

@Peter-Metz
Copy link
Contributor

@martinholmer, thanks for the clear guidance for what needs to be done.

@martinholmer
Copy link
Collaborator

Issue #1694 has been resolved by the merge of pull request #2212.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants