Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Calculator.param method as Calculator.policy_param #1915

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Rename Calculator.param method as Calculator.policy_param #1915

merged 1 commit into from
Mar 14, 2018

Conversation

martinholmer
Copy link
Collaborator

This pull request renames the param method of the Calculator class to policy_param in order to clarify differences between the various types of parameters (Consumption, Behavior, Policy, and more to come).

This is a public API change for users of Tax-Calculator who call the old Calculator.param method in their applications. The Tax-Calculator library has been update internally to use the new Calculator.policy_param method, but other applications will have to be updated by their developers.

@codecov-io
Copy link

codecov-io commented Mar 10, 2018

Codecov Report

Merging #1915 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1915   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          37      37           
  Lines        3319    3319           
======================================
  Hits         3319    3319
Impacted Files Coverage Δ
taxcalc/calculate.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b5637...58c03e5. Read the comment docs.

@martinholmer martinholmer merged commit 977467b into PSLmodels:master Mar 14, 2018
@martinholmer martinholmer deleted the rename-param-method branch March 14, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants