Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare PUF tests for nu06 #2443

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Conversation

Peter-Metz
Copy link
Contributor

@Peter-Metz Peter-Metz commented Jul 29, 2020

The Tax-Data project recently replaced nu05 with nu06 in the PUF (see PSLmodels/taxdata#329). This PR brings Tax-Calculator tests up to speed with the change. Note a slight change of logic in test_puf_var_stats.py so that correlation coefficients are just tested for variables with "taxdata_puf" in records_variables.json.

cc @MattHJensen @andersonfrailey

Edit: Not sure why Travis is failing. Everything passes locally and the Travis log is hard to decipher

Note: the puf.csv file used for this PR was generated with the taxdata Makefile (i.e. make puf-files). As of 8/6, the updated puf.csv has not been distributed to users.

@MattHJensen MattHJensen closed this Aug 5, 2020
@MattHJensen MattHJensen reopened this Aug 5, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #2443 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2443   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          13       13           
  Lines        2577     2582    +5     
=======================================
+ Hits         2575     2580    +5     
  Misses          2        2           
Impacted Files Coverage Δ
taxcalc/utils.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a13cbd4...9b03dc4. Read the comment docs.

@MattHJensen
Copy link
Contributor

Thanks @Peter-Metz, merging.

@MattHJensen MattHJensen merged commit be34878 into PSLmodels:master Aug 5, 2020
@jdebacker jdebacker mentioned this pull request Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants