Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepares 3.2.0 #2604

Merged
merged 12 commits into from Jul 17, 2021
Merged

Prepares 3.2.0 #2604

merged 12 commits into from Jul 17, 2021

Conversation

jdebacker
Copy link
Member

Thanks to @MattHJensen @andersonfrailey @codykallen @amshoulders @chusloj @MaxGhenis for your contributions that are added in this release!

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #2604 (3af2eaa) into master (a0747c3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2604   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          14       14           
  Lines        2611     2611           
=======================================
  Hits         2571     2571           
  Misses         40       40           
Flag Coverage Δ
unittests 98.46% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
taxcalc/__init__.py 100.00% <100.00%> (ø)

@jdebacker
Copy link
Member Author

@MattHJensen I've gone through most of the steps of RELEASING.MD (those that lead up to merging this branch). All unit tests and validation tests pass. However, I was unable to run make tctest-jit without error.

Also, the document says to run the following:

--> cd taxcalc/validation ; ./tests.sh ; .fix. ; cd ../..

The tests.sh ran without error. But when I type .fix. in my terminal, no command is recognized. Not sure if I need this or what I'm doing wrong.

@MattHJensen
Copy link
Contributor

@jdebacker, the .fix. is not a command to the machine but to the human. It's just a note telling you to fix anything that went wrong in the validation. If validation ran without error, then all is good!

@jdebacker
Copy link
Member Author

@MattHJensen Last commit makes what I think are the final changes in this PR, updating RELEASING.MD to note the steps to releasing a new package on conda-forge.

@MattHJensen
Copy link
Contributor

Looks great to me. Thanks for handling this release @jdebacker!

@@ -30,7 +33,8 @@ RELEASING TAX-CALCULATOR CONDA PACKAGES

--> create release X.Y.Z on GitHub using master branch

--> run `pbrelease Tax-Calculator taxcalc X.Y.Z` [to build and upload packages]
--> Create new package on Conda-Forge for release X.Y.Z
--> open a PR to github.com/conda-forge/taxcalc-feedstock where you change the `recipe/meta.yaml` file by updating (1) the version number to X.Y.Z and (2) the checksum to reflectr the checksum for the tarball for release X.Y.Z in the Tax-Calculator GitHub repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo reflectr -> reflect

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch -- just fixed this.

@MattHJensen
Copy link
Contributor

@MattHJensen MattHJensen merged commit 4b5878d into PSLmodels:master Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants